Repository navigation
Conversation
b8991f0 to
e3dcbe9
Compare
b666cb9 to
22c2ba1
Compare
f0351df to
5f12462
Compare
22c2ba1 to
13bef43
Compare
5f12462 to
db05697
Compare
09a7d62 to
bb21fb1
Compare
db05697 to
96fa7a9
Compare
48869aa to
a327498
Compare
d2acc75 to
ec4b08d
Compare
7ceef20 to
bebaf0e
Compare
71e38c9 to
33bb8f7
Compare
bebaf0e to
c6e0de7
Compare
33bb8f7 to
2f27c02
Compare
🛑 Files requiring codeowner reviewTo merge this PR, you'll need to get approvals from the following owners. @MetaMask/swaps-engineers (21 files)
@MetaMask/core-platform (expand for more) |
2f27c02 to
b67a42e
Compare
64aed53 to
49149aa
Compare
268c98b to
8054b4a
Compare
| srcChainId: quote.srcChainId, | ||
| destChainId: quote.destChainId, | ||
| srcTokenAmount: quote.srcTokenAmount, | ||
| slippage: slippagePercentage || quote.slippage, |
There was a problem hiding this comment.
Zero slippage dropped on quote refresh
Low Severity
resolveValidQuotes builds the refresh request with slippagePercentage || quote.slippage. A user-selected slippage of 0 is treated as missing, so the follow-up swap can refresh with a different slippage than the one that was confirmed.
Reviewed by Cursor Bugbot for commit 8054b4a. Configure here.
7a99d50 to
de66319
Compare
8054b4a to
4b4a949
Compare
9a295e5 to
df7a919
Compare
df7a919 to
3c8eec3
Compare
4b4a949 to
85256fd
Compare
03cbb02 to
0bb218b
Compare
85256fd to
ed99e15
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ed99e15. Configure here.
ed99e15 to
c54a23b
Compare


Explanation
References
Checklist
Note
Medium Risk
Touches money-account vault withdrawals, batched transaction submission, and follow-up swap quote refresh—failure modes can block funds movement or use stale quotes, though heavily covered by new tests.
Overview
Adds money-account withdraw as a first-class unified swap/bridge path: a new
submitWithdrawHandlerbuilds vault withdraw + transfer batches (MM Pay approval, optional gas sponsorship on Monad), recordswithdrawTxMetaon history, and can skip a follow-up swap when the destination is the vault underlying token.BridgeStatusControllerroutesmoneyAccountWithdraw/ nested withdraw txs throughwithdrawUpdateHandler, matches history by withdraw batch id, and on confirmation chains into the existing swap/bridge submit path—usingresolveValidQuotesto refresh stale swap quotes viaBridgeController:fetchQuotesandgetQuoteRefreshRate(now exported from bridge-controller and used for polling intervals). Guards reduce duplicate next-step execution and treat “swap already started” as a silent skip.Supporting updates include
withdrawTxMetaon types/history merge, MM PayisPostQuotefor withdraws, and broad withdraw-focused tests.Reviewed by Cursor Bugbot for commit c54a23b. Bugbot is set up for automated code reviews on this repo. Configure here.